evaluation-sankey issueshttps://gitlab.sesync.org/khondula/evaluation-sankey/-/issues2020-11-24T15:26:14Zhttps://gitlab.sesync.org/khondula/evaluation-sankey/-/issues/10Make code less verbose2020-11-24T15:26:14ZQuentin ReadMake code less verboseI think the `draw_by_group` function isn't needed and we can just call `data_to_sxpline` directly. That will save some lines of code. Also we should move some of the code at the top of the app down into the expressions where it's actuall...I think the `draw_by_group` function isn't needed and we can just call `data_to_sxpline` directly. That will save some lines of code. Also we should move some of the code at the top of the app down into the expressions where it's actually used.https://gitlab.sesync.org/khondula/evaluation-sankey/-/issues/9Dynamic sizing of text labels inside strata boxes2020-11-24T14:01:58ZQuentin ReadDynamic sizing of text labels inside strata boxesIt would be good to write some logic to change the size of the strata labels to fit the boxes better. This might involve
- using text wrap to fit the long-ass category names
- using ggrepel to move the labels outside boxes
- using ggfit...It would be good to write some logic to change the size of the strata labels to fit the boxes better. This might involve
- using text wrap to fit the long-ass category names
- using ggrepel to move the labels outside boxes
- using ggfittext to size text to fit boxes
See [this ggalluvial vignette](https://corybrunson.github.io/ggalluvial/articles/labels.html).https://gitlab.sesync.org/khondula/evaluation-sankey/-/issues/3behavior when only 1 column selected2020-11-09T03:37:47ZQuentin Readbehavior when only 1 column selectedCurrently displays uninformative error.
Either improve error message or create a plot with just the stacked bar.Currently displays uninformative error.
Either improve error message or create a plot with just the stacked bar.https://gitlab.sesync.org/khondula/evaluation-sankey/-/issues/5Legend formatting2020-11-09T03:29:23ZQuentin ReadLegend formattingMake it vertical, with full cluster name labels.
Increase vertical height of plot display panel to accommodate.Make it vertical, with full cluster name labels.
Increase vertical height of plot display panel to accommodate.