evaluation-sankey issueshttps://gitlab.sesync.org/khondula/evaluation-sankey/-/issues2020-11-24T15:26:14Zhttps://gitlab.sesync.org/khondula/evaluation-sankey/-/issues/10Make code less verbose2020-11-24T15:26:14ZQuentin ReadMake code less verboseI think the `draw_by_group` function isn't needed and we can just call `data_to_sxpline` directly. That will save some lines of code. Also we should move some of the code at the top of the app down into the expressions where it's actuall...I think the `draw_by_group` function isn't needed and we can just call `data_to_sxpline` directly. That will save some lines of code. Also we should move some of the code at the top of the app down into the expressions where it's actually used.https://gitlab.sesync.org/khondula/evaluation-sankey/-/issues/9Dynamic sizing of text labels inside strata boxes2020-11-24T14:01:58ZQuentin ReadDynamic sizing of text labels inside strata boxesIt would be good to write some logic to change the size of the strata labels to fit the boxes better. This might involve
- using text wrap to fit the long-ass category names
- using ggrepel to move the labels outside boxes
- using ggfit...It would be good to write some logic to change the size of the strata labels to fit the boxes better. This might involve
- using text wrap to fit the long-ass category names
- using ggrepel to move the labels outside boxes
- using ggfittext to size text to fit boxes
See [this ggalluvial vignette](https://corybrunson.github.io/ggalluvial/articles/labels.html).https://gitlab.sesync.org/khondula/evaluation-sankey/-/issues/8Artifact on graphics display2020-11-10T13:23:22ZQuentin ReadArtifact on graphics displayThe colored polygons show a strange artifact with parallel swirly curved lines, especially when there are a large number of clusters displayed. No idea why this is.
![image](/uploads/162ee0fa4b083bd7a611b1b23f465517/image.png)The colored polygons show a strange artifact with parallel swirly curved lines, especially when there are a large number of clusters displayed. No idea why this is.
![image](/uploads/162ee0fa4b083bd7a611b1b23f465517/image.png)https://gitlab.sesync.org/khondula/evaluation-sankey/-/issues/7"Filterable" columns2020-11-24T14:02:27ZQuentin Read"Filterable" columnsFor each column, allow only some of the categories to be selected and regenerate the plot accordingly
"Dropdowns" for each column that dynamically appear would be the ideal way to do this.For each column, allow only some of the categories to be selected and regenerate the plot accordingly
"Dropdowns" for each column that dynamically appear would be the ideal way to do this.https://gitlab.sesync.org/khondula/evaluation-sankey/-/issues/6clicking doesn't always give desired output2020-11-06T16:14:00ZQuentin Readclicking doesn't always give desired outputSomething is going on where the clicking on flows does not always correctly return the desired output, and sometimes returns an error. This happens especially when the user clicks on multiple flows one after the other.Something is going on where the clicking on flows does not always correctly return the desired output, and sometimes returns an error. This happens especially when the user clicks on multiple flows one after the other.https://gitlab.sesync.org/khondula/evaluation-sankey/-/issues/5Legend formatting2020-11-09T03:29:23ZQuentin ReadLegend formattingMake it vertical, with full cluster name labels.
Increase vertical height of plot display panel to accommodate.Make it vertical, with full cluster name labels.
Increase vertical height of plot display panel to accommodate.https://gitlab.sesync.org/khondula/evaluation-sankey/-/issues/4Get the schquiggly wigglies to work2020-11-10T12:36:27ZQuentin ReadGet the schquiggly wigglies to workUse code from ggalluvial and underlying grid functions to extract the coordinates of the curves so that they can be clickable polygons. Currently only works for straight lines (the splines from which the curves are calculated)Use code from ggalluvial and underlying grid functions to extract the coordinates of the curves so that they can be clickable polygons. Currently only works for straight lines (the splines from which the curves are calculated)https://gitlab.sesync.org/khondula/evaluation-sankey/-/issues/3behavior when only 1 column selected2020-11-09T03:37:47ZQuentin Readbehavior when only 1 column selectedCurrently displays uninformative error.
Either improve error message or create a plot with just the stacked bar.Currently displays uninformative error.
Either improve error message or create a plot with just the stacked bar.https://gitlab.sesync.org/khondula/evaluation-sankey/-/issues/2Moar interactivity2020-11-10T03:14:11ZQuentin ReadMoar interactivityFeatures to add might be highlighting flows when you click or hover over one of the factor labels, or drag things around.Features to add might be highlighting flows when you click or hover over one of the factor labels, or drag things around.https://gitlab.sesync.org/khondula/evaluation-sankey/-/issues/1Collapse small factor categories2020-10-15T17:50:31ZQuentin ReadCollapse small factor categoriesSuggestion by Kelly to add a dropdown to say which levels to collapse to "other" using `forcats::fct_collapse()` for better readability in the variables with many categoriesSuggestion by Kelly to add a dropdown to say which levels to collapse to "other" using `forcats::fct_collapse()` for better readability in the variables with many categories